RFR: JDK-8199884: JDK-8199749 broke build with make 3.81
Erik Joelsson
erik.joelsson at oracle.com
Tue Mar 20 19:05:09 UTC 2018
My consistency check in JDK-8199749 broke the build if using make 3.81.
We use make 4.0 most of the time internally so I didn't test with older
make versions. The typical error looks like this:
lib/CompileLibjsig.gmk:92: ***
/Users/erik/hg/jdk-make381/open/build/macosx-x86_64-normal-server-release/support/modules_libs/java.base/libjsig.dylib.dSYM/Contents/Info.plist
was not created for
/Users/erik/hg/jdk-make381/open/build/macosx-x86_64-normal-server-release/support/modules_libs/java.base/libjsig.dylib.
Stop.
make[2]: *** [hotspot-jsig] Error 2
My proposed fix adds a condition around these safety checks so that they
are only performed on known working versions of make.
Webrev: http://cr.openjdk.java.net/~erikj/8199884/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8199884
/Erik
More information about the build-dev
mailing list