8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

[Langer, Christoph]

Hi Matthias,

looks good to me, too.

Best regards
Christoph

From: Baesken, Matthias
Sent: Dienstag, 27. März 2018 09:23
To: Thomas Stüfe <thomas.stuefe at gmail.com>
Cc: build-dev at openjdk.java.net; hotspot-dev at openjdk.java.net; Simonis, Volker <volker.simonis at sap.com>; Doerr, Martin <martin.doerr at sap.com>; Langer, Christoph <christoph.langer at sap.com>
Subject: RE: 8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

Hi Thomas , thanks for the review .

Can I have a second review please ?

Best regards, Matthias

From: Thomas Stüfe [mailto:thomas.stuefe at gmail.com]
Sent: Montag, 26. März 2018 20:14
To: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Cc: build-dev at openjdk.java.net<mailto:build-dev at openjdk.java.net>; hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net>; Simonis, Volker <volker.simonis at sap.com<mailto:volker.simonis at sap.com>>; Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>
Subject: Re: 8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

Hi Matthias,

thanks for fixing this!

Patch works and looks ok.

Best Regards, Thomas

On Mon, Mar 26, 2018 at 4:55 PM, Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:
Hello,  after  recent   adjustments of src/hotspot/share/trace/traceEventClasses.xsl
in jdk/hs     ( see 8196337: Add commit methods that take all event properties as argument ) the AIX build fails.

The  xlC compiler is not happy with

using TraceEvent::commit;

in traceEventClasses.xsl (looks like correct C++ but xlc  12.1 refuses to compile ).
Error messages :

/nightly/output-jdk-hs/hotspot/variant-server/gensrc/tracefiles/traceEventClasses.hpp", line 226.9: 1540-1113 (S) The class template name "TraceEvent" must be followed by a < in this context.


Bug :

https://bugs.openjdk.java.net/browse/JDK-8200246

Adding  the  template  parameter   to TraceEvent   makes  xlc happy too.

http://cr.openjdk.java.net/~mbaesken/webrevs/8200246/


Are you fine with this change ?

Best regards, Matthias