[11] RFR for JDK-8202544: Hide unused exports in libzip
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed May 2 12:02:22 UTC 2018
Looks good to me, FWIW.
/Magnus
> 2 maj 2018 kl. 13:52 skrev Alexey Ivanov <alexey.ivanov at oracle.com>:
>
> Hi,
>
> Could you please review the following fix for jdk11?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8202544
> webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.0/
>
> The following exported functions in libzip are not used:
> ZIP_GetEntry, ZIP_FreeEntry, ZIP_Lock, ZIP_Unlock, ZIP_Read
>
> I removed JNIEXPORT modifiers from these functions. With the fix, they're not exported on Windows; on Linux they're listed as Local rather than Global.
>
> I ran tests, no failures.
>
>
> Thank you in advance.
>
> Regards,
> Alexey
More information about the build-dev
mailing list