RFR(L) : 8199375 : [TESTBUG] Open source vm testbase monitoring tests

[Vladimir Kozlov]

On 5/2/18 11:57 AM, Igor Ignatyev wrote:
> Vladimir,
> 
> we can introduce 'quick' keyword, mark these tests w/ them and use this keyword in test selection. I personally don't like this way either, as it uses a loosely defined property. it also might be possible to create a separate test group file and use it to define only _quick groups. I'll look into these and other possible options.
> 
> in any case, although it will create a temporary mess, I'd prefer not to change how we define these *_quick test groups or how we do test selection, until all vm testbase tests are open sourced as it might create unneeded complications w/ test execution. I'll file an RFE to not forget about it.

Yes, this sounds good. Reviewed.

Thanks,
Vladimir

> 
> Thanks,
> -- Igor
> 
>> On May 2, 2018, at 10:59 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> I wish we have ability to include other files with definitions into TEST.group file. It is very ugly to double size of TEST.group file just for that purpose.
>>
>> Thanks,
>> Vladimir
>>
>> On 5/1/18 9:39 PM, Igor Ignatev wrote:
>>> Vladimir,
>>> Tests are listed only in _quick test group b/c it doesn’t include all tests from the directory. We use this group in some of our test configurations, and :vmTestbase_nsk_monitoring in others. vmTestbase_nsk_monitoring is defined by the directory as other groups.
>>> Thanks,
>>> — Igor
>>>> On May 1, 2018, at 7:54 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>>
>>>> Igor,
>>>>
>>>> Why you need to list each test in TEST.groups and not just directory as we do in other cases?
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>>> On 5/1/18 7:10 PM, Igor Ignatyev wrote:
>>>>> http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
>>>>>> 41276 lines changed: 41274 ins; 1 del; 1 mod;
>>>>> Hi all,
>>>>> could you please review the patch which open sources monitoring tests from vm testbase?
>>>>> The tests were developed to test hotspot related JMX functionality. as w/ common VM testbase code, these tests are old, they have been run from hotspot testing for a long period of time. originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. in a long term, we are planning to rework them.
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8199375
>>>>> webrev:  http://cr.openjdk.java.net/~iignatyev/8199375/webrev.00/index.html
>>>>> testing: vmTestbase_nsk_monitoring test group
>>>>> Thanks,
>>>>> -- Igor
>