RFR: JDK-8202919: JDK-8202683 broke macosx build

[David Holmes]

On 11/05/2018 2:36 AM, Erik Joelsson wrote:
> The macosx build fails with:
> 
> jib > /usr/bin/printf: illegal option -- s
> jib > usage: printf format [arguments ...]
> jib > Copy-java.base.gmk:123: recipe for target 
> '/scratch/mesos/slaves/555f5737-a945-4eb0-8d30-afb1fc816afd-S23/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/6b28d42d-8028-4658-a23d-8f6d3f314161/runs/f48124fc-fd2c-4db3-9cfe-4eddde371989/workspace/build/macosx-x64/support/modules_libs/java.base/jvm.cfg' 
> failed
> 
> Adding -- first on the printf lines fixes this build error.

Seems the affect of 8202683 was not what I expected. It was only 
supposed to allow for the minimal VM to be built/used on 64-bit - I did 
not realize that it changed the way the jvm.cfg file is handled for all 
64-bit platforms!

There should have been a verification on every platform that for 
non-Minimal VM cases the old and new jvm.cfg files are identical. This 
was obviously not done for all platforms. Was it done at all?

David
-----

> Bug: https://bugs.openjdk.java.net/browse/JDK-8202919
> 
> Webrev: http://cr.openjdk.java.net/~erikj/8202919/webrev.01/
> 
> /Erik
>