RFR: JDK-8202920: jvm.cfg generation incorrect

[David Holmes]

Hi Erik,

cc'ing Kumar as he is nominally the owner of the jvm.cfg files.

On 11/05/2018 3:38 AM, Erik Joelsson wrote:
> I took a further look at the jvm.cfg generation and reworked it 
> completely. This change removes all the predefined jvm.cfg files and 
> replaces them with a simple generation script. This should produce the 
> same files as before JDK-8202683 for any configuration Oracle builds 
> officially and zero. For special jvm variant combinations, it will stay 
> closer to the official ones. See bug comments for details.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202920
> 
> Webrev: http://cr.openjdk.java.net/~erikj/8202920/webrev.01/

I'm not sure of the details here. You no longer alias any flags for VMs 
not present, but list them as "ignore". IIUC that means the default VM 
will be selected - so as long as the default VM is the one previously 
aliased to then it is equivalent. I also thought that the first line in 
the file defined the default VM and so had to be a known VM - with these 
changes a client-only build, for example, will have a first entry of 
"-server ignore".

There is always some debate as to whether a non-present VM should be 
ignored or cause an error. For the minimal VM builds we used to do for 
SE Embedded it was chosen to ignore them and just use the Minimal VM. 
This isn't necessarily what everyone would want.

David

> /Erik
>