RFR: JDK-8202920: jvm.cfg generation incorrect

[Aleksey Shipilev]

On 05/11/2018 06:56 AM, David Holmes wrote:
> On 11/05/2018 10:03 AM, Erik Joelsson wrote:
>> On 2018-05-10 15:52, David Holmes wrote:
>>> Given these jvm.cfg files have been slated for removal for a very long time, I don't think you
>>> want to add new configure options related to them. Even this current work is rather a waste of
>>> everyone's time in the circumstance.
>>>
>> You mean the launcher will be reworked? Perhaps it will. However, right now, the combination of
>> JDK-8202919 and JDK-8202683 has quite drastically changed the contents of jvm.cfg, so I'm trying
>> to restore some kind of order short term.
> 
> Personally when the problem with Aleksey's original change was detected I would have rolled it back.
> If you want to restore order by other means, then do so, but that means restoring the previous
> contents of the jvm.cfg files to me.

Yeah, we can backout the original jvm.cfg change, since it produced unexpected breakages. I expected
the change to be innocuous, but in glaring hindsight it wasn't. It was not very essential to begin
with, and if it comes with roadbumps, it is sensible to backout. Erik's "--" MacOS fix is still
good, because it fixed jvm.cfg generation on unusual path.

-Aleksey