[11] RFR for JDK-8202544: Hide unused exports in libzip

[Alexey Ivanov]

Hi Christoph,

Thank you for your review.

I was checking the changeset before pushing and noticed I had forgotten 
to remove JNIEXPORT modifier from ZIP_GetEntry in zip_util.h.

Here's the updated webrev:
http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.1/

The only difference with previous one is in this snippet in zip_util.h:

-JNIEXPORT jzentry *
+jzentry *
  ZIP_GetEntry(jzfile *zip, char *name, jint ulen);


Thank you!

Regards,
Alexey

On 10/05/2018 22:11, Langer, Christoph wrote:
> Hi Alexey,
>
> looks good to me. Symbols don't seem to be needed outside libzip (java.base).
>
> Best regards
> Christoph
>
>> -----Original Message-----
>> From: build-dev [mailto:build-dev-bounces at openjdk.java.net] On Behalf Of
>> Alexey Ivanov
>> Sent: Mittwoch, 9. Mai 2018 16:35
>> To: core-libs <core-libs-dev at openjdk.java.net>; hotspot-dev <hotspot-
>> dev at openjdk.java.net>
>> Cc: build-dev <build-dev at openjdk.java.net>
>> Subject: Re: [11] RFR for JDK-8202544: Hide unused exports in libzip
>>
>> Any volunteers from core-libs and/or hotspot?
>>
>> Thank you,
>> Alexey
>>
>> On 02/05/2018 13:02, Magnus Ihse Bursie wrote:
>>> Looks good to me, FWIW.
>>>
>>> /Magnus
>>>
>>>> 2 maj 2018 kl. 13:52 skrev Alexey Ivanov <alexey.ivanov at oracle.com>:
>>>>
>>>> Hi,
>>>>
>>>> Could you please review the following fix for jdk11?
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8202544
>>>> webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.0/
>>>>
>>>> The following exported functions in libzip are not used:
>>>> ZIP_GetEntry, ZIP_FreeEntry, ZIP_Lock, ZIP_Unlock, ZIP_Read
>>>>
>>>> I removed JNIEXPORT modifiers from these functions. With the fix,
>> they're not exported on Windows; on Linux they're listed as Local rather than
>> Global.
>>>> I ran tests, no failures.
>>>>
>>>>
>>>> Thank you in advance.
>>>>
>>>> Regards,
>>>> Alexey