RFR(XL): 8199712: Flight Recorder

[Erik Joelsson]

Oh, I missed the new makefiles last time I looked at this.

in Copy-jdk.jfr.gmk, everything looks like it's indented an extra 4 
steps. I'm assuming this is because it used to be conditional in the 
previous closed file.

GensrcJfr.gmk, line 94, please move )) to the left.

Looking closer at GensrcJfr.gmk, The macro SetupJfrGeneration looks like 
it is only called once. This could be greatly simplified by just taking 
the body of the macro and inlining all the inputs. This of course unless 
you see a need in the future to generate additional files using the jfr 
tool.

/Erik

On 2018-05-14 07:36, Erik Gahlin wrote:
> Here is an updated webrev:
>
> http://cr.openjdk.java.net/~egahlin/8199712.1/ [1]
>
> that incorporates:
>
> - build changes
> - new event prefix, i.e. "com.oracle.jdk.CPULoad" becomes "jdk.CPULoad"
> - obsolete command line options EnableTracing and UseLockedTracing
> - fixed typos in the Javadoc
> - simplified #include files
>
> RFEs have been filed for other issues, CSR is approved and tests pass.
>
> Erik and Markus
>
> [1] Parent:
>
> changeset:   50092:0e42d3120e51
>
> user:        clanger
> date:        Sat May 12 10:26:42 2018 +0200
> summary:     8202915: [JAXP] Performance enhancements and cleanups in 
> com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator
>
>
>> Greetings,
>>
>> Could I have a review of 8199712: Flight Recorder
>>
>> As mentioned in the preview [1] the tracing backend has been removed. 
>> Event metadata has been consolidated into a single XML file and event 
>> classes are now generated by GenerateJfrFiles.java.
>>
>> Tests have been run on Linux-x64, Windows-x64 and MaxOSX-x64.
>>
>> For details about the feature, see the JEP:
>> https://bugs.openjdk.java.net/browse/JDK-8193393
>>
>> Webrev:
>> http://cr.openjdk.java.net/~egahlin/8199712.0/
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8199712
>>
>> [1] 
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-April/031359.html
>>
>> Thanks
>> Erik and Markus
>