RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

[David Holmes]

Hi Michal,

On 12/11/2018 2:18 PM, Michal Vala wrote:
> 
> 
> On 11/10/18 12:07 AM, David Holmes wrote:
>> cc'ing JC Beyler as this was his code.
>>
>> On 10/11/2018 4:35 AM, Kim Barrett wrote:
>>>> On Nov 9, 2018, at 11:43 AM, Michal Vala <mvala at redhat.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> please review following patch fixing build failure on Windows with 
>>>> VS2013 toolchain.
>>
>> Not sure we're still supporting VS2013 ... ??
> 
> Minimum accepted by configure is 2010. 2013 is 2nd in priorities after 
> 2017. It has `VS_SUPPORTED_2013=false` though, but why not keep it 
> buildable?

That depends on how painful it is to achieve that. As Kim has explained 
the suggested fix may allow building but it isn't correct.

And we may not be able to keep this ability to build with VS2013 going 
forward.

Thanks,
David


>>
>>>>
>>>> http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8213622/webrev.00/
>>>
>>> The failure is in a hotspot test.  It should be using os::snprintf.
>>
>> Tests don't have access to os::snprintf. The test is just C++ code.
>>
>> Cheers,
>> David
>>
>>
>