RFR(S): 8211350: Remove jprt support

[Erik Joelsson]

Looks good to me.

/Erik


On 2018-10-02 11:17, Mikael Vidstedt wrote:
> Thanks for the reviews. I’ve reverted the changes related to Helper and “just” adjusted the comments instead.
>
> webrev:  http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
> incremental (from webrev.00): http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01.incr/open/webrev/
>
>
> Btw, I notice that "Test not run, NO jmods directory” will be printed twice when jmods is missing - once in Helper::newHelper and once in the methods calling it. In general, the handling of a null return from newHelper could use some clean up, but that is out of scope for this change.
>
> Cheers,
> Mikael
>
>> On Oct 2, 2018, at 8:40 AM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>>
>>
>> On 10/2/18 12:21 AM, Mikael Vidstedt wrote:
>>> Please review this change which removes support for, and references to, the (Oracle internal) JPRT system.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8211350 <https://bugs.openjdk.java.net/browse/JDK-8211350>
>>> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/>
>>>
>> test/jdk/tools/lib/tests/Helper.java is used by test/jdk/tools/jimage and test/jdk/tools/jlink tests which will be skipped, rather than failing, when running with images where jmods directory is not present (e.g. exploded image).
>>
>> I think Helper class should continue to return null if jmods does not exist.  test/jdk/tools/jimage/JImageTest.java should also be reverted.
>>
>> Otherwise, the clean up looks good.
>>
>> Mandy