RFR: JDK-8211724: Change mkdir -p to MakeDir macro where possible
Erik Joelsson
erik.joelsson at oracle.com
Fri Oct 5 21:31:31 UTC 2018
As a followup to JDK-8211677, here is an attempt at fixing most other
instances of $(MKDIR) -p to instead of the MakeDir or MakeTargetDir
macros. Since fixing the previous bug, we have hit the race in other
recipes as well so this is really needed.
There are some situations where the macro would not apply, so those have
been skipped. I'm also pretty sure that those are race free. See bug
comment for details.
In addition to this I evaluated the AC_PROG_MKDIR_P macro. It didn't
quite work out for us however. The fallback method if it cannot find a
suitable mkdir binary is to use the build-aux/install.sh script. Our
problem is that we have not included this script in our source (just a
fake empty file) and to include it now would require a lot of legal
work. What I've done instead is to simply add gmkdir first in the list
of programs to look for when searching for mkdir. On Solaris, this is
the program the macro found (and internally we have that installed on
Solaris), so this will at least fix the immediate problem we are
currently facing.
Bug: https://bugs.openjdk.java.net/browse/JDK-8211724
Webrev: http://cr.openjdk.java.net/~erikj/8211724/webrev.01/index.html
/Erik
More information about the build-dev
mailing list