RFR: 8061281: Microbenchmark suite build support, directory layout and sample benchmarks

[Erik Joelsson]

Hello,

In JarArchive.gmk, I would suggest using the MakeTargetDir/MakeDir 
macros. If my patch goes in first, you will likely get a conflict there.

It looks like BuildMicrobenchmarks.gmk is missing in the webrev.

/Erik

On 2018-10-09 06:44, Magnus Ihse Bursie wrote:
>
>
> On 2018-10-09 15:15, Claes Redestad wrote:
>> Hi,
>>
>> please review the initial build support for JEP 230: Microbenchmark 
>> Suite[1].
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8061281/jdk.00/
> The build changes look good. (But I can't really review them as I 
> wrote most of them :-))
>
> As you say, we also need to update documentation, especially 
> doc/testing.md, with the new micro test suite for run-test.
>
> /Magnus
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8061281
>>
>> There are some added steps to be able to build the microbenchmark suite:
>>
>> export JMH_HOME=/path/to/jmh
>> (mkdir -p $JMH_HOME; cd $JMH_HOME; bash 
>> make/devkit/createJMHBundle.sh; tar -zxvf jmh-1.21.tar.gz)
>> bash configure --with-jmh=$JMH_HOME
>> make build-microbenchmark
>>
>> This produces the JMH benchmarks under 
>> build/$CONF_NAME/images/test/micro/microbenchmarks.jar
>>
>> There is also support woven into the make run-test target (thanks to 
>> Magnus), allowing for integrated build and test:
>>
>> make run-test TEST="micro:java.lang.reflect" MICRO="OPTIONS=-f 1 -wi 
>> 2;RESULT_FORMAT=json"
>>
>> Remaining tasks before the JEP can be targetted is to write proper 
>> documentation and deciding which microbenchmarks to migrate from
>> jmh-jdk-microbenchmarks[2].
>>
>> Thanks!
>>
>> /Claes
>>
>> [1] http://openjdk.java.net/jeps/230
>> [2] http://openjdk.java.net/projects/code-tools/jmh-jdk-microbenchmarks/
>