RFR: 8212008: Use of TREAT_EXIT_CODE_1_AS_0 hide problems with jtreg Java

[Jonathan Gibbons]

Unrelated to the proposed change, the test/hotspot/jtreg/Makefile 
contains this line:

   30
   31 USE_JTREG_VERSION := 4.1

That would appear to be somewhat out of date, or (more likely) not used.

-- Jon


On 10/10/2018 09:01 AM, Erik Joelsson wrote:
> Looks good.
>
> A side effect of this is that if no tests are found (also returns 1), 
> make will fail. In our CI system, this will be interpreted as NOT_RUN 
> "no tests found", which is actually an improvement from PASSED "total 
> 0, passed 0, failed 0" as it will be more visible.
>
> /Erik
>
>
> On 2018-10-10 08:47, Christian Tornqvist wrote:
>> Hi,
>>
>> When running JDK and Hotspot jtreg tests through make, 
>> TREAT_EXIT_CODE_1_AS_0 is set to true. Any issue with the Java 
>> installation used to run jtreg won’t be reflected in the exit code. 
>> This has been seen a bunch of times in our internal CI system where 
>> we thought we ran tests but instead no tests were run at all because 
>> the jtreg Java installation had been deleted/corrupted.
>>
>> Webrev: 
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8212008/webrev.00/ 
>> <http://cr.openjdk.java.net/~ctornqvi/webrev/8212008/webrev.00/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8212008 
>> <https://bugs.openjdk.java.net/browse/JDK-8212008>
>>
>> Thanks,
>> Christian
>