RFR: 8212201: Classlist build tool should be built with new javac

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Oct 17 11:57:08 UTC 2018


Looks good to me.

/Magnus

On 2018-10-17 13:55, Claes Redestad wrote:
> Hi again,
>
> stumbled on some failures in pre-integration testing (but not locally, 
> initially) due to having the wrong include:
>
> http://cr.openjdk.java.net/~redestad/8212201/jdk.01
>
> Thanks Magnus for pointing out the very peculiar ways make is silent 
> about missing definitions, leading to weird errors down the line 
> instead of failing fast..
>
> /Claes
>
> On 2018-10-15 21:10, Claes Redestad wrote:
>> Hi,
>>
>> please review this patch to build HelloClasslist / classlist.jar 
>> targetting the latest bytecode version, to ensure the classlist 
>> generation uses all recent features, e.g., indified string concat (as 
>> intended)
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8212201/jdk.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8212201
>>
>> Thanks!
>>
>> /Claes
>




More information about the build-dev mailing list