RFR: JDK-8210958 Rename "make run-test" to "make test"
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Tue Oct 23 08:45:27 UTC 2018
On 2018-10-19 18:11, Erik Joelsson wrote:
> Looks good, and thanks for fixing test-make. I found the same issue
> today.
>
> Could you also change the make target we call for
> run-test/run-test-prebuilt profiles in jib-profiles.js?
There's no target for run-test in jib-profiles.js; only for
run-test-prebuilt (as far as I can understand, at least). I've updated
this, and I also renamed all references to "run-test" to just "test".
Maybe this was going too far. Let me know if you want me to revert that
part.
Updated webrev (only jib-profiles.js has changed):
http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.03
/Magnus
>
> /Erik
>
>
> On 2018-10-19 05:32, Magnus Ihse Bursie wrote:
>> Now that JDK-8212028 is pushed, it's time to revisit this.
>>
>> In the meantime, the compile-command test had been added, which
>> caused me to realize some better handling of the make tests were
>> needed. These fixes are also included. Now "make test-make" will run
>> all build system tests with proper dependencies.
>>
>> I also fixed a test in TestMakeBase.gmk which became broken with
>> JDK-8212028.
>>
>> Updated webrev:
>> http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.02
>>
>>
>> /Magnus
>>
>>
>> On 2018-09-20 12:47, Magnus Ihse Bursie wrote:
>>> The time has come to start phasing out the old test running
>>> framework ("cd test && make"). This patch will change the behavior
>>> of "make test" to use the new run-test framework, instead of the old.
>>>
>>> The old framework is still available as of now by using "cd test &&
>>> make".
>>>
>>> The "run-test" target (and variants like exploded-run-test or
>>> run-test-tier1) are kept as aliases.
>>>
>>> Using "cd test && make" will result in a warning being printed that
>>> it is recommended to stop using this way of running tests.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210958
>>> WebRev:
>>> http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.01
>>>
>>> /Magnus
>>>
>>
>
More information about the build-dev
mailing list