RFR(XS): 8212994: Links to Oracle websites should use "https:"

Erik Joelsson erik.joelsson at oracle.com
Thu Oct 25 20:43:15 UTC 2018


Looks good.

/Erik


On 2018-10-25 13:33, Iris Clark wrote:
> Hi.
>
> Please review changes to use "https" instead of "http" for links in the
> generated JavaDoc API pages:
>
>       8212994:  Links to Oracle websites should use "https:"
>       bug:  https://bugs.openjdk.java.net/browse/JDK-8212994
>       webrev:  https://cr.openjdk.java.net/~iris/8212994/webrev/
>
> I did a full "make docs" build and verified that the old links are
> no longer in the created image.
>
> Thanks,
> iris
>
> $ pwd
> /u/iris/se/full-jdk/build/images
>
> $ find . -name "*.html" -print | xargs grep "http://www.oracle.com/technetwork/java/redist-137594.html" | wc -l
> 0
> $ find . -name "*.html" -print | xargs grep "https://www.oracle.com/technetwork/java/redist-137594.html" | wc -l
> 20312
>
> ## link in banner and footer
> $ find . -name "*.html" -print | xargs grep "http://www.oracle.com/technetwork/java/javase/terms/license/java12speclicense.html" | wc -l
> 0
> $ find . -name "*.html" -print | xargs grep "https://www.oracle.com/technetwork/java/javase/terms/license/java12speclicense.html" | wc -l
> 40624
>
> $ find . -name "*.html" -print | xargs grep "http://bugreport.java.com/bugreport/" | wc -l
> 0
> $ find . -name "*.html" -print | xargs grep "https://bugreport.java.com/bugreport/" | wc -l
> 20312
>
> $ find . -name "*.html" -print | xargs grep "http://www.oracle.com/pls/topic/lookup?ctx=javase12\&amp\;id=homepage" | wc -l
> 0
> $ find . -name "*.html" -print | xargs grep "https://www.oracle.com/pls/topic/lookup?ctx=javase12\&amp\;id=homepage" | wc -l
> 20312




More information about the build-dev mailing list