RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Sep 12 10:46:30 UTC 2018


On 2018-09-11 18:14, Severin Gehwolf wrote:
> Hi Erik,
>
> Thanks for the review!
>
> On Tue, 2018-09-11 at 08:57 -0700, Erik Joelsson wrote:
>> Hello Severin,
>>
>> Even if using the macro, I still think you need to add a condition on
>> the compiler types where the switch can be reasonably expected to exist.
> How about this?
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/webrev.05/
Looks good to me, too.

Thanks for keeping the spirit high despite the high number of respins of 
the patch!

/Magnus

>
> Thanks,
> Severin
>
>> On 2018-09-11 05:02, Severin Gehwolf wrote:
>>> On Mon, 2018-09-10 at 09:29 -0700, Erik Joelsson wrote:
>>>> I see. I was not aware of that issue, but we clearly need to file a bug
>>>> for it and fix it. In this case I think it's fine to us the macro however.
>>> OK. Update webrev, which now uses FLAGS_COMPILER_CHECK_ARGUMENTS.
>>>
>>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/webrev.04/
>>>
>>> Micro-benchmark results from running [1] for x86_64 and ppc64le are
>>> here (-O2 is sufficient it seems):
>>>
>>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/microbenchmarks_results/
>>>
>>> More thoughts?
>>>
>>> Thanks,
>>> Severin
>>>
>>> [1] https://github.com/gromero/strictmath/
>>>
>>



More information about the build-dev mailing list