RFR: JDK-8210731 PropertiesParser does not produce reproducible output

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Sep 13 22:25:54 UTC 2018


+1

-- Jon

On 09/13/2018 03:25 PM, mandy chung wrote:
> Looks okay to me.
>
> Mandy
> P.S. I cc'ed compiler-dev since I think you meant to cc compiler-dev 
> instead of hotspot-compiler-dev.
>
> On 9/13/18 3:20 PM, Magnus Ihse Bursie wrote:
>> The file make/langtools/tools/propertiesparser/PropertiesParser.java 
>> b/make/langtools/tools/propertiesparser/PropertiesParser.java is used 
>> to convert .properties files into .java files as part of the gensrc 
>> step.
>>
>> However, due to it's use of creating it's output directly from 
>> HashMaps, it's not guaranteed to be stable, and is causing spurios 
>> differences in our cmp-baseline builds.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210731
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8210731-properties-parser-is-not-stable/webrev.01
>>
>> /Magnus
>>
>




More information about the build-dev mailing list