RFR: JDK-8210729 Clean up macosx static library handling

[Erik Joelsson]

Hello,

Nice cleanup overall.

In CoreLibraries.gmk: I don't think it's safe to use $(BUILD_LIBFDLIB) 
directly as input to LIBS. That variable may contain other targets as 
well (such as debug symbol files and soon compile_commands.js snippets). 
A safer variable to use is $(BUILD_FDLIBM_TARGET). I even documented 
this as an output variable in NativeCompilation.gmk. I realize this was 
already used before your patch however.

I would expect a certain level of testing to be done for a change like 
this to make sure all affected libraries are verified.

/Erik

On 2018-09-13 15:06, Magnus Ihse Bursie wrote:
> There's a bunch of interrelated smelly code regarding static libraries 
> on macosx.
>
> I started by turning libfdlibm into a static library on macosx, as on 
> all other platforms. It turned out that we don't have proper support 
> for static libraries on macosx, so I fixed this too.
>
> Secondly, I removed the libjli_static.a for macosx. There is no good 
> reason to have it. It's probably just a left-over from the old Apple 
> port to macosx. This in turn prompted some additional related cleanup 
> in LauncherCommon.gmk.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210729
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8210729-cleanup-macosx-static-library-handling/webrev.01
>
> /Magnus
>