RFR: JDK-8210944 Stop replacing -MD with -MT in libwindowsaccessbridge

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Sep 20 07:05:46 UTC 2018


Currently, we are filtering out -MD and replacing it with -MT when 
building libwindowsaccessbridge. This has just been a way to replicate 
the behavior of old build system, and there's no point in doing so.

In fact, it is recommended *not* to mix -MT and -MD in dlls and 
executable, as that might lead to problems (as seen in e.g. JDK-8207139).

Bug: https://bugs.openjdk.java.net/browse/JDK-8210944
Patch inline:
diff --git a/make/lib/Lib-jdk.accessibility.gmk 
b/make/lib/Lib-jdk.accessibility.gmk
--- a/make/lib/Lib-jdk.accessibility.gmk
+++ b/make/lib/Lib-jdk.accessibility.gmk
@@ -69,7 +69,7 @@
          EXTRA_SRC := common, \
          OPTIMIZATION := LOW, \
          DISABLED_WARNINGS_microsoft := 4311 4302 4312, \
-        CFLAGS := $(filter-out -MD, $(CFLAGS_JDKLIB)) -MT \
+        CFLAGS := $(CFLAGS_JDKLIB) \
              -DACCESSBRIDGE_ARCH_$2, \
          EXTRA_HEADER_DIRS := \
              include/bridge \

/Magnus


More information about the build-dev mailing list