RFR: JDK-8210931 JLI and launchers normalization and cleanup
Alan Bateman
Alan.Bateman at oracle.com
Thu Sep 20 11:24:55 UTC 2018
On 20/09/2018 09:32, Magnus Ihse Bursie wrote:
> There's a lot of weird stuff going on with libjli and the launchers.
> Most of it stems from the old build system, which was just copied
> verbatim into the new build system. This is the final part of getting
> JLI to behave like most other libraries.
>
> This patch will:
> * store libjli in the standard lib directory, not in a "jli"
> subdirectory.
> * remove dead code for filtering ergo files, which do no longer exist
> * use file extension to show type (ObjectiveC), rather than -x
> objective-c.
> * use more common constructs in setting up the native compilation
> arguments.
> * clean out unused flags and arguments.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210931
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8210931-jli-normalization/webrev.01
This looks okay to me but I think would be useful to confirm that you've
run the tools/launcher and java.lang.instrument tests. At some point I
hope we can get the JPLIS agent in libinstrument changed to not have the
dependency on JLI but that will require work.
-Alan
More information about the build-dev
mailing list