RFR: JDK-8210705 Stop exporting all symbols on macosx

[Erik Joelsson]

Looks even better.

/Erik


On 2018-09-24 10:33, Magnus Ihse Bursie wrote:
>
> On 2018-09-24 17:43, Erik Joelsson wrote:
>> Looks good.
> Thanks. I realized there's one more part where we still export all 
> symbols on macosx, and that's the launchers. Here's an updated webrev 
> that handles them too:
>
> http://cr.openjdk.java.net/~ihse/JDK-8210705-stop-exporting-all-symbols-on-macosx/webrev.02 
>
>
> /Magnus
>>
>> /Erik
>>
>>
>> On 2018-09-24 02:00, Magnus Ihse Bursie wrote:
>>> For historical reasons, we have exported all symbols on macosx. This 
>>> was an issue that probably arise with the very first macosx port, 
>>> and the complication that we then used map files with a format that 
>>> Xcode did not support.
>>>
>>> Now we don't use mapfiles anymore, and there's no reason to keep 
>>> exporting all symbols on macosx. Instead, we should only export the 
>>> public symbols, just like for all other platforms.
>>>
>>> All platform-independent code is already properly annotated with 
>>> JNIEXPORT, but there was a few files in libosxapp that needed some 
>>> additional JNIEXPORTs.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210705
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8210705-stop-exporting-all-symbols-on-macosx/webrev.01
>>>
>>> /Magnus
>>
>