RFR: JDK-8211037: Load jib jars dynamically from JibArtifactManager

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Sep 24 20:35:45 UTC 2018


On 2018-09-22 02:42, Erik Joelsson wrote:

> Thanks for noticing! How about this:
>
> http://cr.openjdk.java.net/~erikj/8211037/webrev.02/
LGTM.

/Magnus
>
> /Erik
>
> On 2018-09-21 17:03, Jonathan Gibbons wrote:
>> Erik,
>>
>> Note the following API note for Files.list
>> https://docs.oracle.com/javase/10/docs/api/java/nio/file/Files.html#list%28java.nio.file.Path%29 
>>
>>
>> API Note:
>>     This method must be used within a try-with-resources statement or
>>     similar control structure to ensure that the stream's open
>>     directory is closed promptly after the stream's operations have
>>     completed.
>>
>> -- Jon
>>
>> On 09/21/2018 04:38 PM, Erik Joelsson wrote:
>>> We need to avoid always having the jib jars on the classpath when 
>>> running jtreg tests through the makefiles. They interfere with the 
>>> test setup for certain tests. This can be fixed rather easily by 
>>> dynamically loading the classes based on an environment variable set 
>>> by make.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8211037
>>>
>>> Webrev: http://cr.openjdk.java.net/~erikj/8211037/webrev.01/index.html
>>>
>>> /Erik
>>>
>>
>




More information about the build-dev mailing list