RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029)

Aleksey Shipilev shade at redhat.com
Wed Sep 26 16:11:24 UTC 2018


On 09/26/2018 06:08 PM, Schmidt, Lutz wrote:
> Hi Aleksey,
> 
> you got me! I forgot to mention this one, sorry! With -Werror=switch, the compiler complains about line 131 in cpu/s390/assembler_s390.cpp:
> 
>        case bcondNotHigh  + bcondNotOrdered : inverse_cc = bcondHigh; break;                                                     // 13
> 
> The resulting case label was not declared in the enum Assembler::branch_condition.

Sneaky. Dear God. Can we please use the new enum constant in those case labels then? This would be a
fun source of bugs otherwise if "bcondNotHigh  + bcondNotOrdered" carries over some bits :)

-Aleksey





More information about the build-dev mailing list