RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029)

Aleksey Shipilev shade at redhat.com
Thu Sep 27 10:17:57 UTC 2018


On 09/27/2018 12:08 PM, Schmidt, Lutz wrote:
> Hi Aleksey & All, 
> 
> I have changed the "sneaky" code such that it now looks more "enterprise grade". Please find an updated webrev at
> Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8211145.01/ 

Looks much better, thanks.

Should the switches over BasicType in sharedRuntime_s390.cpp be defaulted to ShouldNotReachHere(),
like they are in sharedRuntime_ppc.cpp?

-Aleksey




More information about the build-dev mailing list