RFR: 8221894: Add comments for docker tests in the test doc
Erik Joelsson
erik.joelsson at oracle.com
Thu Apr 4 13:41:32 UTC 2019
Hello Jie,
Looks good, just some grammatical notes on the first paragraph. Here is
my suggestion:
Docker tests with default parameters may fail on OS versions newer than
oraclelinux 7.6.
For example, they pass on Ubuntu 16.04 but fail on Ubuntu 18.04 if run
like this:
/Erik
On 2019-04-03 20:10, Jie Fu wrote:
> Hi Erik,
>
> Thank you for your review.
>
>> Hello Jie,
>>
>> I think this kind of information would fit better under its own new
>> heading to make it more explicit. Then we could continue filling in
>> other similar notes for other tests there. At the bottom, something
>> like:
>>
>> ## Notes for Specific Tests
>>
>> ### Docker Tests
>>
>> <Add basically what you put in the review email here>
>>
>>
>> What do you think?
>
> Very good suggestions.
> Here is the updated version:
> http://cr.openjdk.java.net/~jiefu/8221894/webrev.01/
> Please review.
> Thanks a lot.
>
> Best regards,
> Jie
>
>
More information about the build-dev
mailing list