JDK 14 RFR of JDK-8230373: Use java.io.Serial in generated exception types

Erik Joelsson erik.joelsson at oracle.com
Fri Aug 30 20:47:45 UTC 2019


Looks good.

/Erik

On 2019-08-30 13:12, Joe Darcy wrote:
> Hello,
>
> As noted during the code review of JDK-8229997 
> (http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062049.html), 
> for completeness @java.io.Serial annotation should be included on 
> generated exception types.
>
> Please review the patch below which adds these annotations by updating 
> the generation script.
>
> Thanks,
>
> -Joe
>
> diff -r 374f3f9dda6f make/scripts/genExceptions.sh
> --- a/make/scripts/genExceptions.sh    Fri Aug 30 14:58:40 2019 -0400
> +++ b/make/scripts/genExceptions.sh    Fri Aug 30 13:10:30 2019 -0700
> @@ -1,6 +1,6 @@
>  #! /bin/sh
>  #
> -# Copyright (c) 2000, 2012, Oracle and/or its affiliates. All rights 
> reserved.
> +# Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights 
> reserved.
>  # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  #
>  # This code is free software; you can redistribute it and/or modify it
> @@ -60,6 +60,7 @@
>      extends ${SUPER}
>  {
>
> +    @java.io.Serial
>      private static final long serialVersionUID = $SVUID;
>  __END__
>
>



More information about the build-dev mailing list