RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Mikael Vidstedt mikael.vidstedt at oracle.com
Wed Dec 11 19:30:38 UTC 2019


Christoph,

Thanks for reporting! I filed https://bugs.openjdk.java.net/browse/JDK-8235789 <https://bugs.openjdk.java.net/browse/JDK-8235789> and will send out an RFR shortly.

Cheers,
Mikael

> On Dec 11, 2019, at 1:27 AM, Langer, Christoph <christoph.langer at sap.com> wrote:
> 
> Hi Mikael (or build folks),
> 
> after 8234370 was submitted, I recognize the following output for configure:
> 
> stdin:85: warning: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required
> stdin:85: http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
> /.../jdk/make/autoconf/platform.m4:545: PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET is expanded from...
> stdin:85: the top level
> 
> Would you mind to check (and fix?) this?
> Shall I create a bug?
> 
> Thanks
> Christoph
> 
> 
>> -----Original Message-----
>> From: build-dev <build-dev-bounces at openjdk.java.net> On Behalf Of
>> Mikael Vidstedt
>> Sent: Freitag, 22. November 2019 20:01
>> To: build-dev <build-dev at openjdk.java.net>
>> Subject: Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris
>> and SPARC Ports
>> 
>> 
>> Erik/Tim, thanks for the reviews!
>> 
>> On more small change: Update building.md (and .html) to reflect the
>> deprecation of the ports:
>> 
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open
>> /webrev/
>> <http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/ope
>> n/webrev/>
>> 
>> Let me know if you think of other places where this should be reflected.
>> 
>> Cheers,
>> Mikael
>> 
>>> On Nov 22, 2019, at 6:17 AM, Tim Bell <tim.bell at oracle.com> wrote:
>>> 
>>> Mikael:
>>> 
>>> Looks good to me as well.
>>> 
>>> Tim
>>> 
>>> On 2019-11-22 06:10, Erik Joelsson wrote:
>>>> Looks good.
>>>> /Erik
>>>> On 2019-11-20 12:03, Mikael Vidstedt wrote:
>>>>> 
>>>>> I noticed that most of the configure options include the default value in
>> the help string (in brackets), so here’s an updated webrev which does
>> exactly that:
>>>>> 
>>>>> Webrev:
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/we
>> brev
>>>>> Webrev (incremental):
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open
>> /webrev/
>>>>> 
>>>>> Cheers,
>>>>> Mikael
>>>>> 
>>>>>> On Nov 20, 2019, at 7:47 AM, Erik Joelsson <erik.joelsson at oracle.com
>> <mailto:erik.joelsson at oracle.com>> wrote:
>>>>>> 
>>>>>> Looks good.
>>>>>> 
>>>>>> /Erik
>>>>>> 
>>>>>> On 2019-11-18 15:28, Mikael Vidstedt wrote:
>>>>>>> Please review this change which implements the changes for JEP 362:
>> Deprecate the Solaris and SPARC Ports.
>>>>>>> 
>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
>>>>>>> Webrev:
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/we
>> brev/
>>>>>>> 
>>>>>>> I’ve tested that the expected error message is produced by default,
>> and that running with --enable-deprecated-ports=yes produces a warning
>> instead.
>>>>>>> 
>>>>>>> Cheers,
>>>>>>> Mikael
>>>>>>> 
>>>>> 
>>> 
> 




More information about the build-dev mailing list