RFR: 8235960: Zero should not trigger the deprecation warning for ports

Mikael Vidstedt mikael.vidstedt at oracle.com
Mon Dec 16 19:38:02 UTC 2019


You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. The suggested change will incorrectly *not* produce a warning for solaris/*/zero.

Something like this should do the trick:

    if test "x$OPENJDK_TARGET_OS" = xsolaris || (test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$with_jvm_variants" != xzero); then

Cheers,
Mikael

> On Dec 15, 2019, at 3:20 AM, John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de> wrote:
> 
> Hi!
> 
> JDK-8234370 introduced a deprecation warning for ports that are going to be removed
> in the future. The change in question checks for the target architecture and operating
> system but does however does not account for the Zero variant which doesn't need support
> for a specific target besides a few autonconf definitions and some #ifdef magic.
> 
> This change extends the change from JDK-8234370 to additionally test whether we're building
> the Zero variant. With this change, I can configure OpenJDK Zero on a Linux/SPARC target
> again without getting a deprecation message.
> 
> Please review.
> 
> Thanks,
> Adrian
> 
>> [1] http://cr.openjdk.java.net/~glaubitz/8235960/webrev.00/
> 
> -- 
> .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz at debian.org
> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913




More information about the build-dev mailing list