RFR: 8235960: Zero should not trigger the deprecation warning for ports
Mikael Vidstedt
mikael.vidstedt at oracle.com
Mon Dec 16 21:08:06 UTC 2019
I’m not actually sure, but just to be on the safe side I’d prefer to add the grouping.
Cheers,
Mikael
> On Dec 16, 2019, at 11:45 AM, John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de> wrote:
>
> On 12/16/19 8:40 PM, John Paul Adrian Glaubitz wrote:
>> Hi Mikael!
>>
>> On 12/16/19 8:38 PM, Mikael Vidstedt wrote:
>>> You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. The suggested change will incorrectly *not* produce a warning for solaris/*/zero.
>>>
>>> Something like this should do the trick:
>>>
>>> if test "x$OPENJDK_TARGET_OS" = xsolaris || (test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$with_jvm_variants" != xzero); then
>>
>>
>> Thanks for the review. As far as I remember correctly, Zero is not supported, is it?
> "Zero is not supported on Solaris", I meant. Sorry.
>
> --
> .''`. John Paul Adrian Glaubitz
> : :' : Debian Developer - glaubitz at debian.org <mailto:glaubitz at debian.org>
> `. `' Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de <mailto:glaubitz at physik.fu-berlin.de>
> `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
More information about the build-dev
mailing list