RFR [XS]: 8236274: remove obsolete -d2Zi+ debug flag in MSVC builds

Baesken, Matthias matthias.baesken at sap.com
Fri Dec 20 14:37:06 UTC 2019


Thanks for the reviews !


Best regards, Matthias


> 
> Hi,
> 
> I don't think another review is needed, but FWIW this looks good to
> me!
> 
> /Claes
> 
> On 2019-12-20 11:03, Baesken, Matthias wrote:
> > Hi Erik,   thanks for the review !  I'll remove the comment line .
> >
> > May I get a second review ?
> >
> > Best regards, Matthias
> >
> >>
> >> Hello Matthias,
> >>
> >> Looks good except for the comment. There is no need to add a comment
> for
> >> something that has been removed, it will just look confusing.
> >> Documenting it in the JBS issue is enough.
> >>
> >> Thanks for cleaning this up!



More information about the build-dev mailing list