RFR [XS] : 8218562: handle HOTSPOT_BUILD_COMPILER for clang/xlclang and cleanup HOTSPOT_BUILD_COMPILER settings
david.holmes at oracle.com
Thu Feb 7 11:44:47 UTC 2019
On 7/02/2019 9:38 pm, Magnus Ihse Bursie wrote:
> On 2019-02-07 10:36, David Holmes wrote:
>> Hi Matthias,
>> On 7/02/2019 1:17 am, Baesken, Matthias wrote:
>>> Hello, please review this small change .
>>> I noticed (when looking into AIX xlc16 / xlclang++) the
>>> following: in the case that clang is used for compilation,
>>> HOTSPOT_BUILD_COMPILER claims to be a gcc .
>>> This is a bit misleading.
>>> This change adjusts the setting for clang usage on AIX (for future
>>> usage with xlclang++) and macOSX.
>>> Additionally I removed some old HOTSPOT_BUILD_COMPILER for legacy
>>> Oracle / Sun Studio versions ).
>> Possibly more could be removed :)
>> Changes seem fine.
>> I've always been irked by the fact we can access an actual version
>> string from the compilers themselves, so we wouldn't need this code.
> How do you do that?
Sorry typo s/we can access/we can't access/
> I'm having this kind of background low-intensity itch to fix the
> duplication between hotspot and build system in this (and related system
> detection code). It never rises to enough annoyance to actually get me
> to do anything about it, though.
I guess configure could generate a version string for hotspot to use,
but it's probably not the brief version string we prefer to have.
>>> Bug/webrev :
>>> Thanks, Matthias
More information about the build-dev