RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries
mandy.chung at oracle.com
Thu Feb 7 20:43:06 UTC 2019
Using the plugin specific ResourceBundle is good. Thanks for making
I see that Alan's comment  on the plugin options and I assume
you will investigate the plugin options and bring back a proposal.
Did I miss the discussion on these options?
I suggest the above be simplified and drop the "=defaults". Simply:
If include-debug-syms=true then it will run
objcopy --only-keep-debug foo foo.<ext> to create debug symbols file
objcopy --add-gnu-debuglink=foo.dbg foo
So what about simplifying the options to:
We could also drop the word "symbols":
By default, `--strip-native-debug` will strip native debug symbols
and don't keep debug symbols.
keep-debug=<debug-file-ext> creates the debug symbols file.
<debug-file-ext> specifies the file extension. It would be
nice to use the default `debuginfo` extension and simply
accept `keep-debug` option.
`objcopy-cmd` may be okay too. Others may have opinion.
I think we should agree on the plugin options first before
doing the code review.
W.r.t. the test:
> The test currently only runs on Linux
> and requires objcopy to be available. Otherwise the test is being
We can create a fake objcopy utility for testing purpose
such that the test will validate if the options are passed
properly to the test utility.
I haven't reviewed the new files. Just notice that very long
lines in the new files that you may want to fix the formatting
that will help further side-by-side review.
The --list-plugin output is very very long. The existing plugins
didn't set a good example to keep the well formatted (I recorded
that they were cleaned up at one point to keep 80 chars width).
One other question: should this plugin be moved to linux/classes
rather than unix/classes given that that's the platform it
intends to support?
More information about the build-dev