C4819 warnings on Windows

[Yasumasa Suenaga]

Thanks Erik!

I will push the change of 8216155 to jdk/jdk then I receive the result from submit repo.


Yasumasa


On 2019/01/04 18:09, Erik Joelsson wrote:
> Hello Yasumasa,
> 
> Looking at the freetype header, the non ascii characters are all in comments, so ignoring the warning should be fine. Consider JDK-8216155 reviewed.
> 
> /Erik
> 
> On 2019-01-04 09:47, Yasumasa Suenaga wrote:
>> Thanks David!
>> I filed two issues to JBS:
>>
>>   https://bugs.openjdk.java.net/browse/JDK-8216154
>>   https://bugs.openjdk.java.net/browse/JDK-8216155
>>
>> Patches have been pushed to submit repo. I will send RFR when I receive result from submit repo.
>>
>>
>> Yasumasa
>>
>>
>> On 2019/01/04 16:44, David Holmes wrote:
>>> Hi Yasumasa,
>>>
>>> The two hotspot issues can be filed in one bug under hotspot->compiler and reviewed on hotspot-compiler-dev as they are source code changes not build changes.
>>>
>>> The other one is a build change but probably also needs reviewing by awt-dev.
>>>
>>> Cheers,
>>> David
>>>
>>> On 4/01/2019 5:22 pm, Yasumasa Suenaga wrote:
>>>> Hi all,
>>>>
>>>> I tried to build OpenJDK on WSL (Windows 10 1809 + VS2017 (15.9.4) + Ubuntu 18.04 LTS).
>>>> However, I saw some C4819 warnings as below:
>>>>
>>>> ```
>>>> c:/OpenJDK/jdk/src/hotspot/share/compiler/methodMatcher.cpp(258): warning C4819: ファイルは、現在のコード ページ (0) で表示できない文字を 含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存し てください。
>>>> ```
>>>>
>>>> * The locale of my laptop is set to Japanese (CP932), thanks :-)
>>>>
>>>>
>>>> I saw this warning at 3 files as below:
>>>>
>>>>    1. hotspot/share/code/codeHeapState.cpp
>>>>    2. java.desktop/share/native/libfreetype/src/autofit/afscript.h
>>>>    3. hotspot/share/compiler/methodMatcher.cpp
>>>>
>>>> We can see the problem in 1. and 2. with iconv:
>>>>    $ iconv -f US-ASCII -t UTF8 <file>
>>>>
>>>>
>>>> I've fixed them with following patch. It works fine on my environment:
>>>>    http://cr.openjdk.java.net/~ysuenaga/wsl/build-warnings/
>>>>
>>>> I think we should fix them, but I don't know what component/subcomponent should we set to JBS.
>>>> Could you help?
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Yasumasa