C4819 warnings on Windows

[Erik Joelsson]

On 2019-01-04 10:50, Yasumasa Suenaga wrote:
> Hi Max,
>
> I do not have Cygwin, so I can't build on it.
>
> I guess this issue has two causes:
>
>
>   1. VS 2017 - I guess submit repo uses VS 2015 for Windows builds.

We use VS2017 at Oracle (which includes the submit repo), but the update 
is 15.5.5. We are planning on bumping this for JDK 13.

/Erik

>   2. Locale - I use Windows which locale is set to Japanese, so C 
> compiler might be hit any encoding issue(s).
>
>
> Anyway, these codes has characters which are out of range of us-ascii. 
> So we might hit some issues in the future.
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2019/01/04 18:29, Weijun Wang wrote:
>> Just curious, why were you mentioning WSL and Ubuntu? Isn't this a 
>> pure Windows build issue? Or is it possible to use WSL instead of 
>> Cygwin to launch the build process now? That's unbelievable.
>>
>> Thanks,
>> Max
>>
>>> On Jan 4, 2019, at 3:22 PM, Yasumasa Suenaga <yasuenag at gmail.com> 
>>> wrote:
>>>
>>> Hi all,
>>>
>>> I tried to build OpenJDK on WSL (Windows 10 1809 + VS2017 (15.9.4) + 
>>> Ubuntu 18.04 LTS).
>>> However, I saw some C4819 warnings as below:
>>>
>>> ```
>>> c:/OpenJDK/jdk/src/hotspot/share/compiler/methodMatcher.cpp(258): 
>>> warning C4819: ファイルは、現在のコード ページ (0) 
>>> で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを 
>>> Unicode 形式で保存してください。
>>> ```
>>>
>>> * The locale of my laptop is set to Japanese (CP932), thanks :-)
>>>
>>>
>>> I saw this warning at 3 files as below:
>>>
>>>   1. hotspot/share/code/codeHeapState.cpp
>>>   2. java.desktop/share/native/libfreetype/src/autofit/afscript.h
>>>   3. hotspot/share/compiler/methodMatcher.cpp
>>>
>>> We can see the problem in 1. and 2. with iconv:
>>>   $ iconv -f US-ASCII -t UTF8 <file>
>>>
>>>
>>> I've fixed them with following patch. It works fine on my environment:
>>>   http://cr.openjdk.java.net/~ysuenaga/wsl/build-warnings/
>>>
>>> I think we should fix them, but I don't know what 
>>> component/subcomponent should we set to JBS.
>>> Could you help?
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>