[PATCH] Request for Review: Override TESTDIRS correctly in tests

[Siddhesh Poyarekar]

On 04/01/19 7:24 PM, Erik Joelsson wrote:
> So what you want to achieve is running all the tests in hotspot/test? I 
> doubt that's a very good idea, but you should be able to achieve that 
> with this command line:
> 
> make test TEST=jtreg_tests TESTDIRS=../hotspot/test/.
> 
> The TESTDIRS parameter is only valid with the "jtreg_tests" target in 
> test/Makefile, which you reach by setting the "TEST" variable on the 
> command line to the top level target "test". Other targets in 
> test/Makefile correspond to jtreg test groups.

That worked, thanks!

> The suggested patch looks like it risks breaking other use cases. I 
> would avoid tinkering with those makefiles unless absolutely necessary 
> as they are brittle (which is why we rewrote them).

Understood, thank you for the explanation.

Siddhesh