RFR: JDK-8216278: Fix devkit and basic Jib support on WSL

[Andrew Luo]

Hi Erik,

Looks good to me also (not a reviewer though, thought I'd chime in since I've worked a bit with WSL)

One question:

This line: MAKE_EXPECTED_ENV='x86_64-.*-linux-gnu' - what other strings did you see other than -pc- - just asking out of curiosity.

Thanks,

-Andrew

-----Original Message-----
From: build-dev <build-dev-bounces at openjdk.java.net> On Behalf Of Tim Bell
Sent: Wednesday, January 9, 2019 10:54 AM
To: Erik Joelsson <erik.joelsson at oracle.com>
Cc: build-dev <build-dev at openjdk.java.net>
Subject: Re: RFR: JDK-8216278: Fix devkit and basic Jib support on WSL

Erik:

Looks good to me.

/Tim

On 01/09/19 10:14, Erik Joelsson wrote:
> The WSL support in the build does not currently work with devkits. 
> This prevents us from using Jib to configure a WSL build. This patch 
> fixes configure to work with devkits when building for Windows in WSL.
>
> (For Oracle users, I also managed to get Jib working in WSL, and able 
> to configure both Windows and Linux profiles. Note that since Jib is 
> not WSL aware itself, you need to manually direct the data dir to a 
> location visible from Windows. e.g --with-data-dir 
> /mnt/c/cygwin64/var/tmp/jib-$USER).
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216278
>
> Webrev: http://cr.openjdk.java.net/~erikj/8216278/webrev.01/index.html
>
> /Erik
>