RFR: JDK-8216489: Issues with ModulePackages attribute generation on incremental build

Tim Bell tim.bell at oracle.com
Thu Jan 10 18:01:27 UTC 2019


Erik:

Looks good.

I agree with Alan - that is a very subtle typo.

Tim

On 01/10/19 09:23, Alan Bateman wrote:
> On 10/01/2019 17:14, Erik Joelsson wrote:
>> The incremental build of exploded-image-optimize is broken. This is
>> caused by a small typo in the prerequisites declaration for the recipe.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8216489
>>
>> Webrev: http://cr.openjdk.java.net/~erikj/8216489/webrev.01/
> Looks good, I'm sure we could stare at that line for several minutes
> before spotting it.
>
> BTW: If it helps then the tool to add this attribute could easily be
> modified to update specific modules rather than all. That might help
> with some incremental build cases to avoid scanning all modules.
>
> -Alan




More information about the build-dev mailing list