RFR: JDK-8215952: NetBeans pre-build failed due to the incorrect configuration

[Jie Fu]

Hi Magnus,

Thanks a lot for your review and helpful comments.

The patch[1] had been tested with Apache NetBeans IDE 9.0 (Build 
incubator-netbeans-release-334-on-20180708) on a Linux_64 (amd64) machine.
I've noticed that all files under the specified root will be scanned 
automatically when the nb_project is opened in NetBeans.
And all automatically generated files in build/**/gensrc can be found 
properly by NetBeans.

I compared the configurations-old.xml (the original NB-config file) with 
configurations-new.xml (the new fully generated one after applying the 
patch).
--------------------------------------------------------------------------
fool at fool-OptiPlex-7060:~$ grep build configurations-old.xml | grep 
gensrc | grep macosx -v | wc -l
44
fool at fool-OptiPlex-7060:~$ grep build configurations-new.xml | grep 
gensrc | grep macosx -v | wc -l
91
--------------------------------------------------------------------------
More items of build/**/gensrc in configurations-new.xml.

--------------------------------------------------------------------------
fool at fool-OptiPlex-7060:~$ grep build configurations-old.xml | grep 
gensrc | grep x86 | grep macosx -v | wc -l
27
fool at fool-OptiPlex-7060:~$ grep build configurations-new.xml | grep 
gensrc | grep x86 | grep macosx -v | wc -l
91
--------------------------------------------------------------------------
More items of build/**/gensrc/**/*x86* in configurations-new.xml too.

--------------------------------------------------------------------------
fool at fool-OptiPlex-7060:~$ grep x86_64 configurations-old.xml | grep 
macosx -v | grep build | wc -l
45
fool at fool-OptiPlex-7060:~$ grep x86_64 configurations-new.xml | grep 
macosx -v | grep build | wc -l
332
--------------------------------------------------------------------------
Also more items of build/**/*x86_64* in configurations-new.xml.

It seems that the src-dependent part of the new config file which was 
generated automatically is more complete and reliable (without invalid 
items).
And I guess most of the original config file was also automatically 
generated by NetBeans based on a relatively old version of OpenJDK.

I'm very sorry that it's really difficult and probably uncomfortable to 
review such a huge patch.
But it would be worth making the NB-config file independent of the 
source code.

Compared with the original NB-config file, I couldn't find any loss of 
functionality with the new one.
Could you please tell me what functionality will be lost?
Thanks.

[1] http://cr.openjdk.java.net/~aoqi/8215952/webrev.01/

Best regards,
Jie


On 2019/1/15 下午9:48, Magnus Ihse Bursie wrote:
> On 2019-01-03 08:22, Fu Jie wrote:
>> Thanks Alan for your review and valuable advice.
>>
>> I think it's worth keeping a NB project in the repo since it seems 
>> more convenient for IDE developers.
>> And to keep configurations.xml current is also important.
>>
>> I made a patch to fix the issue mentioned by Alan.
>> Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.01/
>
> It looks much cleaner. I'm just worried, like Alan, that this actually 
> means a loss of functionality. Is NetBeans scanning all files under 
> the specified root, and will automatically find generated files in 
> build/**/gensrc?
>
> On the other hand, there are few NetBeans users left out there, and 
> you might very well represent a majority of them. :-) So if this works 
> for you, I'm OK with the change. Please just be ready to assist if 
> this breaks the usage for some other NB users.
>
> /Magnus