RFR [XS] 8217233: Update build settings for AIX/xlc

[Baesken, Matthias]

Hi Steve,
from my experience the  situation is similar to Linux  (small  performance change).

Best regards, Matthias


From: Steve Groeger <GROEGES at uk.ibm.com>
Sent: Mittwoch, 16. Januar 2019 10:49
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>; ppc-aix-port-dev at openjdk.java.net; ppc-aix-port-dev <ppc-aix-port-dev-bounces at openjdk.java.net>
Subject: Re: RFR [XS] 8217233: Update build settings for AIX/xlc

Hi Matthias,

The change looks OK.

The docs state: "This option is disabled by default because it can cause performance degradation."
Do you know whether using this option actually causes any performance degradation on AIX?

Thanks
Steve Groeger
IBM Runtime Technologies
Hursley, Winchester
Tel: (44) 1962 816911  Mobex: 279990  Mobile: 07718 517 129
Fax (44) 1962 816800
Lotus Notes: Steve Groeger/UK/IBM
Internet: groeges at uk.ibm.com<mailto:groeges at uk.ibm.com>

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From:        "Baesken, Matthias" <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
To:        "'build-dev at openjdk.java.net'" <build-dev at openjdk.java.net<mailto:build-dev at openjdk.java.net>>, "ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>" <ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>>
Date:        16/01/2019 09:26
Subject:        RFR [XS] 8217233: Update build settings for AIX/xlc
Sent by:        "ppc-aix-port-dev" <ppc-aix-port-dev-bounces at openjdk.java.net<mailto:ppc-aix-port-dev-bounces at openjdk.java.net>>
________________________________



Hello,  please review this small fix .

It adds  stack protection compile flags for xlc/AIX .

See :

https://www.ibm.com/support/knowledgecenter/SSGH2K_12.1.0/com.ibm.xlc121.aix.doc/compiler_ref/opt_stackprotect.html


"Provides protection against malicious code or programming errors that overwrite or corrupt the stack."
The patch will set the stack protection flags .


(  Similar changes have been done for Linux :   8199552: Update to build scripts
https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8b060cdf0251
Introduced stack protection compile flags for Linux/gcc  ( -fstack-protector ) .   )


Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8217233

http://cr.openjdk.java.net/~mbaesken/webrevs/8217233.0/


Thanks, Matthias


Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU