RFR: JDK-8217638 Remove old way of running tests (test/Makefile)

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Jan 24 01:16:04 UTC 2019


I'm OK.  Old friends fade away ...

-- Jon

On 1/23/19 4:19 PM, Erik Joelsson wrote:
> If Jon is ok with the langtools test makefile removal, then this looks 
> good to me.
>
> /Erik
>
> On 2019-01-23 15:49, Magnus Ihse Bursie wrote:
>>> 23 jan. 2019 kl. 17:43 skrev Jonathan Gibbons 
>>> <jonathan.gibbons at oracle.com>:
>>>
>>> There's test/langtools/Makefile as well; is there a reason why it is 
>>> not included here?
>> Yes, there is! :-) It's just not a very good reason: I missed it. :-(
>>
>> Thank you for your diligence! I'll remove it as well.
>>
>> /Magnus
>>
>>
>>> -- Jon
>>>
>>>> On 1/23/19 5:43 AM, Magnus Ihse Bursie wrote:
>>>> The new RunTest method has been used by both developers and CI 
>>>> systems for quite some time. In <a href="/browse/JDK-8210958" 
>>>> title="Rename "make run-test" to "make test"" class="issue-link" 
>>>> data-issue-key="JDK-8210958"><strike>JDK-8210958</strike></a>, the 
>>>> old method was deprecated and a warning was printed to stop using 
>>>> it. Now the time has come to finally remove the old cruft.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217638
>>>>
>>>> The webrev or hg diff would not make much sense, here's a "hg 
>>>> status" of the removed files instead:
>>>>
>>>> $ hg status
>>>> R test/Makefile
>>>> R test/TestCommon.gmk
>>>> R test/hotspot/jtreg/Makefile
>>>> R test/jaxp/Makefile
>>>> R test/jdk/Makefile
>>>> R test/nashorn/Makefile
>>>>
>>>> /Magnus



More information about the build-dev mailing list