RFR: JDK-8217634 RunTest documentation and usability update
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu Jan 24 10:11:31 UTC 2019
On 2019-01-23 18:33, Erik Joelsson wrote:
> Hello,
>
> This looks good. Just one note, the example "configure
> --with-jcov=.../jcov.jar" is incorrect. The configure parameter
> expects a jcov home dir with lib/jcov.jar in it. For a better user
> experience, perhaps the configure arg should be changed to accept both?
Ah, I see. No, we can't change the behavior of the configure flag; I
checked the code and we also assume that
$(JCOV_HOME)/lib/jcov_network_saver.jar exists. (In fact, maybe we
should verify this in configure...)
I'll update the example to be correct.
/Magnus
>
> /Erik
>
> On 2019-01-23 05:25, Magnus Ihse Bursie wrote:
>> The RunTest documentation (doc/testing.md) has not been properly
>> updated with the latest changes.
>>
>> Also, some newly added keywords were not classified as STRING, but as
>> SINGLE to ParseKeywordVariable, which means that the user would not
>> have the quoting support that should have been available.
>>
>> I also added in some whitespace fixes, for good measure.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217634
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/JDK-8217634-runtest-love-and-care/webrev.01
>>
>> /Magnus
More information about the build-dev
mailing list