[8u] RFR: 8210761: libjsig is being compiled without optimization

Andrew John Hughes gnu.andrew at redhat.com
Wed Jul 10 14:01:11 UTC 2019



On 10/07/2019 10:24, Severin Gehwolf wrote:
> Hi Christoph,
> 
> On Wed, 2019-07-10 at 09:08 +0000, Langer, Christoph wrote:
>> Hi Severin,
>>
>> You made a little mistake. It must be "-xO4" instead of "-x04" in the
>> Solaris build file (It's the letter O instead of the number 0) ��
> 
> Sigh. Take 5:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/05/webrev/
> 
> Thanks again for your help!
> 
> Cheers,
> Severin
> 

Looks good to me. I had a look to see if there was a cleaner way of
getting the right flags for Solaris, but it seems this is part of the
whole misuse of CFLAGS as C++ flags that is all over the old HotSpot
build. So this is fine.

Incidentally, make/solaris/makefiles/sparcWorks.make is full of
conditionals to switch between -xO4 and -xO3 for different architectures
and compiler versions, even down to the single file. I don't know how
valid most of this still is, but best to leave it alone at this stage.

Probably my favourite bit of bit rot is:

# Pick which compiler is validated

ifeq ($(JRE_RELEASE_VER),1.6.0)
  # Validated compiler for JDK6 is SS11 (5.8)

  VALIDATED_COMPILER_REVS   := 5.8
  VALIDATED_CC_COMPILER_REVS := 5.8
else
  # Validated compiler for JDK7 is SS12 update 1 + patches (5.10)

  VALIDATED_COMPILER_REVS   := 5.10
  VALIDATED_CC_COMPILER_REVS := 5.10
endif

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the build-dev mailing list