RFR [XS] 8227834: build.log output from failing commands : include the hs_error file path in case of crashes in build - was :RE: build.log: Output from failing command(s) repeated here - do not miss the hs_error file in case of crashes

[Baesken, Matthias]

Hello I prepared a small change to address the mentioned issue .
Please review !

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8227834

http://cr.openjdk.java.net/~mbaesken/webrevs/8227834.0/


Best regards, Matthias



> Hi Matthias,
> 
> I would second that.
> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: build-dev <build-dev-bounces at openjdk.java.net> On Behalf Of
> > Baesken, Matthias
> > Sent: Dienstag, 16. Juli 2019 16:40
> > To: 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>
> > Subject: [CAUTION] build.log: Output from failing command(s) repeated
> > here - do not miss the hs_error file in case of crashes
> >
> > Hello,   In case  of JVM crashes in the build  (yes they happen in
> development
> > 😉 )  , we  print some info about the crash  at the end of the build log file
> >  In the   Output from failing command(s) repeated here  … section  .
> > This looks like  the following   (from a recent crash on AIX )  :
> >
> > === Output from failing command(s) repeated here ===
> > /opt/freeware/bin/printf "* For target jdk__optimize_image_exec:\n"
> > * For target jdk__optimize_image_exec:
> > (/opt/freeware/bin/grep -v -e "^Note: including file:" <   /nightly/output-
> jdk-
> > test/make-support/failure-logs/jdk__optimize_image_exec.log || true) |
> > /opt/freeware/bin/head -n 12
> > #
> > # A fatal error has been detected by the Java Runtime Environment:
> > #
> > #  SIGSEGV (0xb) at pc=0x3c0009003cc0a080, pid=34341128, tid=258
> > #
> > # JRE version: OpenJDK Runtime Environment (14.0.1) (build 14.0.0.1-
> > internal+0-adhoc.openjdk.jdk)
> > # Java VM: OpenJDK 64-Bit Server VM (14.0.0.1-internal+0-
> > adhoc.openjdk.jdk, mixed mode, tiered, compressed oops, serial gc, aix-
> > ppc64)
> > # Problematic frame:
> > # C  0x3c0009003cc0a080
> > #
> > # Core dump will be written. Default location:    /nightly/jdk/make/core or
> > core.34341128
> > #
> >
> > Unfortunately ,  we miss  the path to the hs_error file   which  is a pity
> > because  this  is a VERY important  info  in the  error analysis .
> >
> > The reason seems to be  that  we currently only  print  12 lines   (head -n 12)
> > and  this is not ehought to get the line with the hs_error file .
> > Could we switch to  15 lines ,  this would include  the hs_error file .
> >
> > Change  would be done in  jdk/make/InitSupport.gmk     where
> > PrintFailureReports   is  done .
> >
> >
> > Best regards, Matthias
> >