[8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

Andrew John Hughes gnu.andrew at redhat.com
Mon Jul 29 15:32:47 UTC 2019



On 29/07/2019 11:10, Severin Gehwolf wrote:
> On Mon, 2019-07-29 at 10:19 +0100, Andrew Dinn wrote:
>> On 26/07/2019 18:32, Andrew John Hughes wrote:
>>> On 26/07/2019 16:53, Severin Gehwolf wrote:
> [...]
>>>>
>>>>> What exactly is being pushed
>>>>> here?
>>>>
>>>> The following 4 patches:
>>>>
>>>> jdk:       http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/04/jdk/webrev/
>>>> hotspot:   http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/hotspot/webrev/
>>>> langtools: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/langtools/webrev/
>>>> top:       http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/top/webrev/
>>>>
>>>> Each of them has a reference to a plain patch file if you prefer to
>>>> review that.
>>>>
>>>> Thanks,
>>>> Severin
>>>>
>>>
>>> Ok. HotSpot, JDK & top look fine, but there seem to be a lot of changes
>>> in langtools. Are these original changes to this patch or are they
>>> backports? Is there a reason langtools needs so much more work than the
>>> others?
>> The langtools Makefile changes appear to be larger because they required
>> adding a load of definitions/macros that are already present in the
>> Makefiles in the other trees (i.e. AWK, CAT etc, ZIP_UP_RESULTS,
>> BUNDLE_UP_AND_EXIT etc). These changes look ok to me.
> 
> Yes, exactly. The langools Makefile looks *very* different from
> jdk/hotspot. In order to get some unified status of test results across
> all three, these changes were needed. I've opted to make the langools
> Makefile look more like the ones from jdk and hotspot.
> 
> Old "make test" from top-level continues to work with these changes
> (modulo -verbose:nopass=> summary change).
> 
> Anyway, I had another look at this and made 8075546[1] another pre-
> requisite which makes the langtools changes slightly smaller. Updated
> webrevs set, thus, is:
> 
> jdk:       http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/04/jdk/webrev/
> hotspot:   http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/hotspot/webrev/
> langtools: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/05/langtools/webrev/
> top:       http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/top/webrev/
> 
> Thanks,
> Severin
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8075546
> 

Right. That doesn't answer the question as to the origin of the changes.
If I look at the langtools Makefile in OpenJDK 11, it doesn't have these
changes. Should they not go there first if they are needed?

Update releases are primarily for backports, so I'm dubious of anything
that brings in a bunch of apparently new changes without making it clear
why there are needed and why a backport is not appropriate.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the build-dev mailing list