jdk/jdk (+jdk12) Build failure on OSX 10.11

[Baesken, Matthias]

Hello,  it comes  from the  MacOSX SDK,  the value

NSWindow.h:61:    NSWindowStyleMaskDocModalWindow 		= 1 << 6,

can be found  in   MacOSX10.12.sdk   and    MacOSX10.13.sdk  .
From the info I found here :

https://en.wikipedia.org/wiki/Xcode#Xcode_7.0_-_11.x_(since_Free_On-Device_Development)

XCode 8 and higher   come with at least   MacOSX  SDK   10.12  .
So checking for  the Xcode version might make more sense .


Best regards, Matthias


> -----Original Message-----
> From: Erik Joelsson <erik.joelsson at oracle.com>
> Sent: Mittwoch, 19. Juni 2019 19:30
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'build-
> dev at openjdk.java.net' <build-dev at openjdk.java.net>
> Cc: Schuenemann, Rene <rene.schuenemann at sap.com>
> Subject: Re: jdk/jdk (+jdk12) Build failure on OSX 10.11
> 
> Are you sure it's 10.11 that is the problem and not the version of Xcode?
> 
> /Erik
> 
> On 2019-06-19 00:51, Baesken, Matthias wrote:
> > Hello,  I noticed that we fail  on OSX 10.11  in the build   .  Reason is  that
> NSWindowStyleMaskDocModalWindow  is used since :
> >
> > https://hg.openjdk.java.net/jdk/jdk/rev/6daafebf8189
> >
> > 8208543: [macos] Support for apple.awt.documentModalSheet incomplete
> >
> > Which is 10.12+ functionality . See
> >
> >
> https://developer.apple.com/documentation/appkit/nswindowstylemask/n
> swindowstylemaskdocmodalwindow?language=objc
> >
> > NSWindowStyleMaskDocModalWindow
> > The window is a document-modal panel (or a subclass of
> NSPanel<https://developer.apple.com/documentation/appkit/nspanel?lang
> uage=objc>).
> > macOS 10.12+
> >
> >
> >
> > I would prefer to test for  minimum  10.12  already  in  configure  , what do
> you think ?
> >
> > Best regards, Matthias
> >