Fwd: [RFR] [8u] 8220397: JDK-8036003 backport regresses no_strip builds

[Erik Joelsson]

Looks good.

/Erik

On 2019-03-13 17:27, Andrew John Hughes wrote:
> Forwarding to build-dev for wider review.
>
> -------- Forwarded Message --------
> Subject: [RFR] 8220397: JDK-8036003 backport regresses no_strip builds
> Date: Mon, 11 Mar 2019 07:33:16 +0000
> From: Andrew John Hughes <gnu.andrew at redhat.com>
> To: 'jdk8u-dev at openjdk.java.net' <jdk8u-dev at openjdk.java.net>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8220397
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8220397/webrev.01/
>
> When JDK-8036003 was backported, it added a bunch of conditionals in
> make/common/NativeCompilation.gmk which cause debuginfo to not be
> generated if no_strip is set. However, the cases for ZIP_DEBUGINFO_FILES
> were missed, causing the build to fail, because there's no dependency
> for the .diz target.
>
> I suspect this doesn't show up when the new configure option is
> specified, because ZIP_DEBUGINFO_FILES is toggled appropriately, but it
> does regress my existing builds which don't specify that option.
>
> Simple fix and 8u only.