[RFR]: 8223667: ASAN build broken

[Erik Joelsson]

On 2019-05-10 18:47, David Holmes wrote:
> Does this fix really work? If you do this in a shell then you lose the 
> second option:
>
> > export ASAN_OPTIONS=handle_segv=0 detect_leaks=0
> > echo $ASAN_OPTIONS
> handle_segv=0
>
This is a makefile and not shell. The "export" keyword, while looking 
like shell, is still just a makefile keyword here so makefile syntax 
applies to the variable assignment. This reminds me that we would prefer 
:= instead of = here.

/Erik

> ??
>
> David
>
> On 11/05/2019 10:43 am, Man Cao wrote:
>> Looks good.
>>
>> -Man
>>
>>
>> *From: *Erik Joelsson <erik.joelsson at oracle.com>
>> *Date: *Fri, May 10, 2019 at 9:11 AM
>> *To: *Arthur Eubanks
>> *Cc: *build-dev
>>
>> Looks good.
>>>
>>> /Erik
>>>
>>> On 2019-05-10 09:02, Arthur Eubanks wrote:
>>>>
>>>>      Do you really need to use $(SPACE)? I would expect it to work 
>>>> with
>>>>      just
>>>>      removing the quotes.
>>>>
>>>> You're right, no need for $(SPACE).
>>>> Updated webrev:
>>>> http://cr.openjdk.java.net/~aeubanks/8223667/webrev.01/index.html
>>>