[13] RFR: 8221431: Support for Unicode 12.1
Roger Riggs
Roger.Riggs at oracle.com
Thu May 23 17:47:00 UTC 2019
Hi Naoto,
Looks ok.
src/java.base/share/legal/icu.md: Line 7: Can the copyright character
be changed to (c) to make it easier to check copyrights
Thanks, Roger
On 05/22/2019 09:36 PM, naoto.sato at oracle.com wrote:
> Hi Erik,
>
> Thank you for your comments. Updated the webrev accordingly:
>
> https://cr.openjdk.java.net/~naoto/8221431/webrev.04/
>
> Naoto
>
> On 5/22/19 4:13 PM, Erik Joelsson wrote:
>> Hello Naoto,
>>
>> In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the
>> double $$. I would recommend calling the newer MakeTargetDir macro
>> instead. It doesn't take an argument.
>>
>> Otherwise build changes look good.
>>
>> /Erik
>>
>> On 2019-05-22 15:56, naoto.sato at oracle.com wrote:
>>> Adding build-dev, as the change adds a small build tool to parse
>>> emoji-data.
>>>
>>> Naoto
>>>
>>> On 5/22/19 3:26 PM, naoto.sato at oracle.com wrote:
>>>> Hi,
>>>>
>>>> Please review the changes to the following issue:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8221431
>>>>
>>>> The proposed CSR and changeset are located at:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8222771
>>>> https://cr.openjdk.java.net/~naoto/8221431/webrev.03/
>>>>
>>>> This enhancement incorporates support for the recently released
>>>> Unicode version 12.1. Besides the usual addition of new
>>>> characters/scripts, this enhancement includes normalization of the
>>>> Japanese Reiwa era character (U+32FF), and up-to-date extended
>>>> grapheme cluster support in regex package.
>>>>
>>>> Naoto
More information about the build-dev
mailing list